Skip to content

feat(dursto): make functions using Resolver return Result#770

Merged
vapourismo merged 1 commit intomainfrom
santnr/resolver-fallible
Feb 17, 2026
Merged

feat(dursto): make functions using Resolver return Result#770
vapourismo merged 1 commit intomainfrom
santnr/resolver-fallible

Conversation

@NSant215
Copy link
Contributor

@NSant215 NSant215 commented Feb 2, 2026 •
edited
Loading

Part of RV-892.
Part of RV-894.

What

Refactor methods using the resolver to return a Result rather than absolute value (though keeping the Error type to Infallible for now, with generic types being introduced in a later PR.

Why

Moves us closer to being able to use the resolver for blinding and lazy loading nodes.

The next step will be to make the Id type and error types generic. This will be done in #795

How

Manually Testing

make all

Tasks for the Author

  • Link all Linear issues related to this MR using magic words (e.g. part of, relates to, closes).
  • Eliminate dead code and other spurious artefacts introduced in your changes.
  • Document new public functions, methods and types.
  • Make sure the documentation for updated functions, methods, and types is correct.
  • Add tests for bugs that have been fixed.
  • Explain changes to regression test captures when applicable.
  • Write commit messages in agreement with our guidelines.
  • Self-review your changes to ensure they are high-quality.
  • Complete all of the above before assigning this MR to reviewers.

@codecov
Copy link

codecov bot commented Feb 2, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.07%. Comparing base (80bfe8b) to head (9b15ca4).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #770      +/-   ##
==========================================
- Coverage   91.08%   91.07%   -0.02%     
==========================================
  Files         111      111              
  Lines       20964    20964              
  Branches    20964    20964              
==========================================
- Hits        19096    19092       -4     
- Misses       1491     1495       +4     
  Partials      377      377

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch 2 times, most recently from f090b73 to d8748ee Compare February 3, 2026 09:46
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from d8748ee to 8bd8997 Compare February 3, 2026 14:08
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from 8bd8997 to 7b08ced Compare February 3, 2026 14:30
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from 7b08ced to 046bb04 Compare February 3, 2026 17:01
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch 2 times, most recently from edfacfe to ebad67d Compare February 4, 2026 11:05
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from ebad67d to b9d2fef Compare February 4, 2026 11:39
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from b9d2fef to bd05f39 Compare February 4, 2026 11:43
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from bd05f39 to d792b08 Compare February 4, 2026 13:42
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from d792b08 to 3b3c0e7 Compare February 4, 2026 13:50
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch 2 times, most recently from f0b16d3 to 53297e8 Compare February 5, 2026 09:52
Base automatically changed from santnr/resolver to main February 5, 2026 13:07
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch 3 times, most recently from 10b51d1 to 4b20377 Compare February 6, 2026 17:00
@NSant215 NSant215 changed the title feat(dursto): make Resolver trait fallible feat(dursto): make functions using Resolver return Result Feb 6, 2026
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch 2 times, most recently from e3ce608 to 1286291 Compare February 11, 2026 17:21
vapourismo
vapourismo reviewed Feb 11, 2026
View reviewed changes
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch 3 times, most recently from 0db6457 to 6302eda Compare February 12, 2026 15:23
@vapourismo vapourismo mentioned this pull request Feb 12, 2026
Merged
9 tasks
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from 6302eda to 2415214 Compare February 12, 2026 17:27
@NSant215 NSant215 changed the base branch from main to ole/push-vtywzosmovko February 12, 2026 17:28
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from 2415214 to b139a3b Compare February 12, 2026 17:43
@NSant215
Copy link
Contributor Author

NSant215 commented Feb 12, 2026

@vapourismo @thomasathorne @kurtisc @emturner @zcabter I have rebased on Ole's error refactor branch that has removed the need for infallible everywhere.

@NSant215 NSant215 requested a review from vapourismo February 12, 2026 17:45
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from b139a3b to 4807f6f Compare February 13, 2026 09:33
NSant215
NSant215 commented Feb 13, 2026
View reviewed changes
@vapourismo vapourismo force-pushed the ole/push-vtywzosmovko branch from 2edd59c to e14864c Compare February 13, 2026 10:38
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from 4807f6f to a178c3b Compare February 13, 2026 11:34
Base automatically changed from ole/push-vtywzosmovko to main February 13, 2026 13:52
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from a178c3b to 0e20387 Compare February 13, 2026 13:59
vapourismo
vapourismo approved these changes Feb 13, 2026
View reviewed changes
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch 2 times, most recently from 242ba46 to 64719e8 Compare February 15, 2026 14:47
@NSant215 NSant215 requested a review from vapourismo February 15, 2026 14:48
emturner
emturner reviewed Feb 16, 2026
View reviewed changes
Copy link
Contributor

@emturner emturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending comment re hash fallibility, but otherwise would be happy to approve if that's going to be tackled down the line

victor-dumitrescu
victor-dumitrescu approved these changes Feb 17, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emturner emturner emturner approved these changes

@jobjo jobjo Awaiting requested review from jobjo jobjo is a code owner

@thomasathorne thomasathorne Awaiting requested review from thomasathorne thomasathorne is a code owner

@zcabter zcabter Awaiting requested review from zcabter zcabter is a code owner

@kurtisc kurtisc Awaiting requested review from kurtisc kurtisc is a code owner

@vapourismo vapourismo Awaiting requested review from vapourismo vapourismo is a code owner

@victor-dumitrescu victor-dumitrescu Awaiting requested review from victor-dumitrescu victor-dumitrescu is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@NSant215 @victor-dumitrescu @vapourismo @thomasathorne @kurtisc @emturner @zcabter